Channels
  • s

    seph

    2 years ago
    For this git submodule info, I dumped a bunch of info into https://github.com/osquery/osquery/issues/5862 The failure cases I have, are all in git 2.7. (cc: @alessandrogario @theopolis)
  • theopolis

    theopolis

    2 years ago
    Thanks for this investigation. The cheat-codes for making
    git
    verbose are very helpful. Potential bad news is that I recall trying a newer
    git
    (2.23?) and seeing a failure.
  • s

    seph

    2 years ago
    Interesting. I’d certainly believe it happens.
    It all feels a bit fragile.
  • theopolis

    theopolis

    2 years ago
    CMake might need a
    -DOSQUERY_LIBRARIES_FULL_CLONE
    option
  • s

    seph

    2 years ago
    Maybe. But if it’s just a couple, we can make them non-shallow. Or see if a more recent git ref alleviates it.
    We might also get better behavior from github, if we can refer to a tag, not a ref. But that feels less controlled.
    All goes back to needing a reproduce case ¯\_(ツ)_/¯
  • Stefano Bonicatti

    Stefano Bonicatti

    2 years ago
    Also, Linux with 2.23.0 fails