Channels
packetzero
2 years agoSo back to adding a 3rd party lib. I created the following files : libraries/cmake/source/conveyor/CMakeLists.txt libraries/cmake/source/modules/Findconveyor.cmake third-party/conveyor/osquery.library third-party/conveyor/BUCK Added new submodule: libraries/cmake/source/conveyor/src Updated /CMakeLists.txt: +"Linux,Darwin,Windows:conveyor"
Yet, I still get the following cmake error: CMake Error at CMakeLists.txt:148 (find_package): By not providing "Findconveyor.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "conveyor", but CMake did not find one. Could not find a package configuration file provided by "conveyor" with any of the following names: conveyorConfig.cmake conveyor-config.cmake
Stefano Bonicatti
2 years agothat's really strange.. I just tried just to add the Findconveyor.cmake file and the "Linux,Darwin,Windows:conveyor", and works here. Though I have a suspicion. Could you try to run from the build dir (I'm assuming you're on Linux)
and copy here what comes out?cmake -LAH <source_dir> | grep CMAKE_MODULE_PATHpacketzero
2 years agoi'm on MacOSStefano Bonicatti
2 years agoah I see, should be the same 🙂
at the same time, have you tried deleting the
file and reconfiguring?CMakeCache.txtpacketzero
2 years agoCMAKE_MODULE_PATH:STRING=/Users/me/osq/osquery/cmake/modules;/Users/me/osq/osquery/libraries/cmake/source_migration/modules;/Users/me/osq/osquery/libraries/cmake/facebook/modules;/Users/me/osq/osquery/libraries/cmake/source_migration/modules;/Users/me/osq/osquery/libraries/cmake/facebook/modules;/Users/me/osq/osquery/libraries/cmake/source_migration/modules;/Users/me/osq/osquery/libraries/cmake/facebook/modulesStefano Bonicatti
2 years agoI've just found a bug where some paths to the modules folder gets added each time one configures with CMake.. so I wonder if you hit some limit there and everything goes haywire from there.packetzero
2 years agoyeah, I usually delete cache file before I run cmake.Stefano Bonicatti
2 years agohum ok, so those paths seems fine right?
meaning, at first look they seem but, are they correctly pointing to an existing path? (the ones in CMAKE_MODULE_PATH)packetzero
2 years agoyes they do
this is a good version, right? cmake version 3.15.4Stefano Bonicatti
2 years agooh wait, I got it now. You have to use source_migration, because for macOS we are only getting some library from source
you need to use the other path, not
butsourcesource_migrationpacketzero
2 years agoah... will try that.
thxStefano Bonicatti
2 years agoThough if that's a library that goes on all platform, then I would leave it in
, but write anothersource
which simply includes the one underFind<library>.cmake
, as we are doing right nowsourcepacketzero
2 years agoAnd that is case whether I use a submodule or download a tgz ?Stefano Bonicatti
2 years agoYes, but what you do then in the Find<library>.cmake is different, specifically in how you provide the targets
or actually no, scratch that, this is still the source layer, sorry I was thinking to binary releasespacketzero
2 years agookay, so I am adding a filelibraries/cmake/source_migration/modules/Findconveyor.cmakeStefano Bonicatti
2 years agoyeah, which should just include the other Find under source
as we are doing for the other libraries which we have "migrated"packetzero
2 years agothanks @Stefano Bonicatti That got me past it.
View count: 1