https://github.com/osquery/osquery logo
#core
Title
# core
s

Stefano Bonicatti

01/31/2020, 3:32 PM
though the point is that you should be formatting before committing ^^'
s

seph

01/31/2020, 3:33 PM
I agree with the theory, but I don’t think that’s a reasonable ask for occasional or first time contributors
s

Stefano Bonicatti

01/31/2020, 4:04 PM
How so? Formatting before committing is just a matter of "building" the
format
target, it's one command. I've also recently updated a bit the information about formatting. If it's a problem of the contributing guide being difficult to follow, I think it's worth improving it. As Alessandro said there are some technical challenges too with using
clang-format
directly, we would have to compile the same version of clang-format for all the platforms and provide that
s

seph

01/31/2020, 4:29 PM
I saw your update! We only god as far as we did because it it.