https://github.com/osquery/osquery logo
#core
Title
# core
s

seph

08/24/2021, 2:37 PM
The codesign pipeline is kinda dicy for sha releases. How do folks feel about tagging a 5.0.0.pre1 tag? (Not release)
s

sharvil

08/24/2021, 2:59 PM
noticed that with sha too for Linux
I guess we could try with
5.0.0.pre1
? Wonder if @theopolis or @thor have any quick ideas regarding the codesign workflow that we just tried
s

seph

08/24/2021, 5:21 PM
I bailed on testing it. It seems like if we’re going to cut a pre1 we should test that
m

Mike Myers

08/24/2021, 5:22 PM
if someone with those rights can tag that, we'll test
s

seph

08/24/2021, 5:23 PM
I think we might be at a point where we need a 5.0.0 or a 5.0.pre1 or something like that to test
I’d love thoughts from more people about cutting a pre-release tag. We haven’t done it before, so I’m always wary of unforseen effects.
But it seems like it’s probably the right approach
Note this is not a merge freeze. But instead a tag to facilitate package testing
m

Mike Myers

08/24/2021, 5:24 PM
Worst-case scenario, the codesign workflows will fail, but that's what creating a tag is meant to discover so we can fix it right
👍 1
t

thor

08/24/2021, 6:02 PM
Yeah I'm largely indifferent to pre-release tags. I also don't see much wrong with tagging 5.0.0, then immediately/shortly after cutting a 5.0.1 to fix any outstanding issues with the pipeline
I almost feel like that'll be expected given the magnitude of this release
t

theopolis

08/24/2021, 6:19 PM
Yeah I vote the same way, prefer 5.0.0 over a new convention. Then use 5.0.1 or 5.0.2/etc.
👍 3
Please remember to use the testing S3 bucket when you are testing that workflow.
👍 2
8 Views