seph
theopolis
theopolis
theopolis
Chris Broome
09/12/2019, 1:11 PMosquery/filesystem/windows/fileops.cpp
there are 2 macros defined for min
and max
. What’s the reason for doing that instead of using, say, std::min
and std::max
?seph
theopolis
javuto
09/14/2019, 4:42 PMzwass
--reference
or --dissociate
would prevent copying the whole repo. But still I don't think we can set a depth of 1 since it's unlikely we will want the latest commit. Not sure that we can set any specific depth.Chris Broome
09/17/2019, 3:47 PMBOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE
. Would it be worth it to add -DBOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE
to the top-level CMakeLists.txt file for Windows? I don’t believe I get those same warnings on MacOS for examplezwass
In file included from /Users/zwass/dev/osquery/osquery/tables/system/darwin/packages.mm:19:
/Users/zwass/dev/osquery/build/ns_osquery_tables_system_systemtable/osquery/tables/system/darwin/packages.h:41:14: warning: flexible array members are a C99 feature [-Wc99-extensions]
BOMPointer blockPointers[];
^
/Users/zwass/dev/osquery/build/ns_osquery_tables_system_systemtable/osquery/tables/system/darwin/packages.h:61:8: warning: flexible array members are a C99 feature [-Wc99-extensions]
char name[];
^
/Users/zwass/dev/osquery/build/ns_osquery_tables_system_systemtable/osquery/tables/system/darwin/packages.h:81:18: warning: flexible array members are a C99 feature [-Wc99-extensions]
BOMPathIndices indices[];
^
/Users/zwass/dev/osquery/build/ns_osquery_tables_system_systemtable/osquery/tables/system/darwin/packages.h:99:8: warning: flexible array members are a C99 feature [-Wc99-extensions]
char linkName[];
^
/Users/zwass/dev/osquery/build/ns_osquery_tables_system_systemtable/osquery/tables/system/darwin/packages.h:111:8: warning: flexible array members are a C99 feature [-Wc99-extensions]
char name[];
^
5 warnings generated.
Chris Broome
09/18/2019, 3:04 PMmanu
09/24/2019, 10:46 AMtheopolis
zwass
format_check
is failing on CI (https://dev.azure.com/trailofbits/osquery/_build/results?buildId=883&view=logs&jobId=70c7356e-0f98-5371-69fa-6cc33513ad22), while it passes for me locally on my mac.Stefano Bonicatti
09/25/2019, 6:10 PMpacketzero
09/26/2019, 6:15 PMtheopolis
com.facebook.osquery
to com.osquery.osquery.osquery
(vendor+project+component) and will ask for help from the mac admins community.theopolis
Stefano Bonicatti
10/03/2019, 12:29 AMalessandrogario
yossarian
10/04/2019, 6:42 PMseph
seph
theopolis
theopolis
seph
alessandrogario
alessandrogario
alessandrogario